httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: 2.0.31 coredump on daedalus
Date Sun, 03 Feb 2002 17:40:31 GMT
On Sun, Feb 03, 2002 at 12:24:21PM -0500, Greg Ames wrote:
> (gdb) p r->the_request
> $1 = 0x813f7f8 "POST / HTTP/1.1"
> (gdb) p r->hostname
> $2 = 0x8140370 "search.apache.org"
> (gdb) fr 3
> #3  0x805ed10 in ap_http_filter (f=0x8140388, b=0x813f798,
>     mode=AP_MODE_READBYTES, block=APR_BLOCK_READ, readbytes=29)
>     at http_protocol.c:664
> 664         AP_DEBUG_ASSERT(totalread > 0);
> (gdb) list
> 659         /* How many bytes did we just read? */
> 660         apr_brigade_length(b, 0, &totalread);
> 661
> 662         /* If this happens, we have a bucket of unknown length.  Die because
> 663          * it means our assumptions have changed. */
> 664         AP_DEBUG_ASSERT(totalread > 0);

#3  0x805ed10 in ap_http_filter (f=0x8140388, b=0x813f798, 
    mode=AP_MODE_READBYTES, block=APR_BLOCK_READ, readbytes=29)
    at http_protocol.c:664
664     AP_DEBUG_ASSERT(totalread > 0);
(gdb) print totalread
$1 = 0

Oh, no.  That assert should be >= 0.  I wanted to limit -1 brigades
not 0-length ones.  *sigh*

I hate asserts.  I don't even know why I put it in there.  This is
exactly why it is a bad idea to have debug asserts change code.  Oh,
man.

How about rolling .32 as the same as .31 with that line changed?
(Could you make this change on daedalus - that should fix it.)
-- justin


Mime
View raw message