httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <...@covalent.net>
Subject FW: problem with AddOutputFilterByType directive
Date Tue, 19 Feb 2002 23:27:04 GMT
> On Mon, Feb 18, 2002 at 09:17:19PM -0800, Ian Holsman wrote:
> > it doesn't do what it is supposed to do ALL the time.
> >
> > for example.. take mod-status.
> >
> > inside the handler it decides what type of content-type
> > the program will return.
> 
> "bad module, fix module."

That's bogus.  Consider mod_cgi, which can't determine the content type
until the first bucket is written.

I'm with Ian on this one.

> > 	*) add a filter (with a priority of -1 FTYPE_CONTENT) which just
> > 	   checks the content-type and adds the other filter if it
> >  	   passes.
> 
> If we have to do this, then I think our architecture is in poor
> shape.  I don't think a filter is the right place to do this - there
> is way too much overhead in a filter to do this logic.  And, we'd
> also be adding a filter after we've sent data down the filter chain.
> 
> (Don't get me wrong, I see your rationale behind this, but if the
> only way to do this is via another filter, we've got problems.)
> 
> I could be wrong, but I think the way I did it is the right way to
> do this given what we have now.  Anyone else?  Am I wrong?  -- justin

We have a function, ap_pass_brigade(), which is called by every content
generator, by definition.  Just put a hook into that function.

Ryan



Mime
View raw message