Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 52103 invoked by uid 500); 17 Jan 2002 00:02:26 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 52090 invoked from network); 17 Jan 2002 00:02:26 -0000 X-Authentication-Warning: mako.covalent.net: dougm owned process doing -bs Date: Wed, 16 Jan 2002 16:08:41 -0800 (PST) From: Doug MacEachern X-Sender: dougm@localhost To: dev@httpd.apache.org Subject: Re: [patch] new mod_ssl input filter In-Reply-To: <20020116191145.GH15991@ebuilt.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Wed, 16 Jan 2002, Justin Erenkrantz wrote: > Perhaps you *could* read all of the brigade in the getline case in > bio_bucket_io_read, but that's not a sticking point (as I see your > point - ap_getline *should* be able to pick up on an incomplete > line). i was just trying to avoid blocking forever if all available data had already been read. probably could be done a better way. i was sorta hoping core_input_filter could be split to avoid the getline duplication, but that is another topic. > Assuming that you've run this through httpd-test. -- justin yes. apache/limit 9,10 fail with t/TEST -ssl, but that was also the case before the patch. i debugged a bit and might be an issue on the client side. i will look into it later.