httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_negotiation.c
Date Tue, 29 Jan 2002 16:13:54 GMT
   I asked this question yesterday but I didn't get a reply.  I don't
know if you are still working on this problem or if this is a different
issue, but as it stands, mod_negotiation doesn't do anything.    The
reason is because a check for "dirent.filetype != APR_REG" was added but
APR_FINFO_TYPE was not requested in the call to apr_dir_read().  The
only information that was asked for in the call to apr_dir_read() is
APR_FINFO_DIRENT which appears to be equivalent to APR_FINFO_NAME. 
Since APR_FINFO_TYPE was not asked for, the check for "dirent.filetype
!= APR_REG" will always be true and no files will be negotiated.  If
APR_FINFO_TYPE is added, then stat() will be called for every file which
will be extremely expensive.  Can the check for "dirent.filetype !=
APR_REG" be removed? 

thanks,
Brad

>>> gregames@apache.org Monday, January 28, 2002 2:18:10 PM >>>
gregames    02/01/28 13:18:10

  Modified:    modules/mappers mod_negotiation.c
  Log:
  backing out fix for missing path info and query string.  wrowe beat
me to
  it.
  
  Revision  Changes    Path
  1.93      +0 -4      httpd-2.0/modules/mappers/mod_negotiation.c
  
  Index: mod_negotiation.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_negotiation.c,v
  retrieving revision 1.92
  retrieving revision 1.93
  diff -u -r1.92 -r1.93
  --- mod_negotiation.c	28 Jan 2002 18:43:19 -0000	1.92
  +++ mod_negotiation.c	28 Jan 2002 21:18:10 -0000	1.93
  @@ -2892,10 +2892,6 @@
           }
       }
   
  -    /* preserve path info and query string from the original request
*/
  -    sub_req->path_info = r->path_info;
  -    sub_req->args = r->args;
  -    
       /* now do a "fast redirect" ... promotes the sub_req into the
main req */
       ap_internal_fast_redirect(sub_req, r);
   
  
  
  

begin 644 mod_negotiation.c.txt
M+2TM(%QT96UP87!A8VAE7&AT='!D+3(N,%QM;V1U;&5S7&UA<'!E<G-<;6]D
M7VYE9V]T:6%T:6]N+F,)36]N($IA;B`R."`Q,SHQ,#HQ,2`R,#`R#0HK*RL@
M;6]D7VYE9V]T:6%T:6]N+F,)36]N($IA;B`R."`Q-#HP,CHQ,2`R,#`R#0I`
M0"`M,3`W-"PX("LQ,#<T+#$R($!`#0H@#0H@("`@("`@("`O*B!$;VXG="!N
M96=O=&EA=&4@9&ER96-T;W)I97,@86YD(&]T:&5R('5N=7-U86P@9FEL97,-
M"B`@("`@("`@("`J+PT*+2`@("`@("`@:68@*&1I<F5N="YF:6QE='EP92`A
M/2!!4%)?4D5'*0T**R`@("`@("`@+RH@(%A86"!4:&ES(&EN9F]R;6%T:6]N
M('=A<R!N979E<B!A<VME9"!F;W(@:6X@=&AE(&-A;&P@=&\@#0HK("`@("`@
M("`@("`@(&%P<E]D:7)?<F5A9"@I('1H97)E9F]R92!A;&P@9FEL97,@=VEL
M;"!F86EL(&%N9"!N;W1H:6YG#0HK("`@("`@("`@("`@('=I;&P@8F4@;F5G
M;W1I871E9"`J+PT**R\J("`@("`@("!I9B`H9&ER96YT+F9I;&5T>7!E("$]
M($%04E]214<I#0H@("`@("`@("`@("`@8V]N=&EN=64[#0HK*B\-"B`-"B`@
M("`@("`@("\J($]K+"!S;VUE=&AI;F<G<R!H97)E+B`@36%Y8F4@;F]T:&EN
M9R!U<V5F=6PN("!296UE;6)E<B!T:&%T#0H@("`@("`@("`@*B!W92!T<FEE
M9"P@:68@=V4@8V]M<&QE=&5L>2!F86EL+"!S;R!W92!C86X@<F5J96-T('1H
,92!R97%U97-T(0T*
`
end

Mime
View raw message