httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <>
Subject [1.3 PATCH] more information in log after a byterange seek failure
Date Wed, 16 Jan 2002 19:29:29 GMT
I know how strongly Apache folks feel about rigorously testing code,
so I have to admit that I've never successfully hit this path :)  It
looks to me that it should work okay, though.

An Apache user on Win32 did though, and it would have been useful to
have the filename to know whether or not that was the sort of file
that would change frequently on that server.  (maybe the file changed
between the open and the seek?  I dunno)

Index: http_core.c
RCS file: /cvs/apache/apache-1.3/src/main/http_core.c,v
retrieving revision 1.302
diff -u -r1.302 http_core.c
--- http_core.c	2002/01/09 19:47:03	1.302
+++ http_core.c	2002/01/16 19:04:27
@@ -3880,8 +3880,8 @@
 		    if (fseek(f, offset, SEEK_SET)) {
 			ap_log_error(APLOG_MARK, APLOG_ERR, r->server,
-			      "Failed to fseek for byterange (%ld, %ld)",
-			      offset, length);
+			      "Failed to fseek for byterange (%ld, %ld): %s",
+			      offset, length, r->filename);
 		    else {
 			ap_send_fd_length(f, r, length);

Jeff Trawick | | PGP public key at web site:
             Born in Roswell... married an alien...

View raw message