httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <>
Subject Re: [PATCH] install_core_filters hook
Date Mon, 28 Jan 2002 14:52:31 GMT
"Bill Stoddard" <> writes:

> install_core_filters (please feel free to find another name) is a RUN_FIRST hook that
> after ap_update_vhost_given_ip(c) and right before ap_run_pre_connection.  It's primary
> purpose in life is to create the net_core_rec structure and install the CORE_IN| CORE_OUT
> filters (or alternate primary network i/o filters with hints from the vhost config if
> needed). The client socket is removed from the conn_rec and placed in the net_core_rec
> where only the primary network i/o filters can access it.
> This is much the same as Ryan's 11/12 patch I -1'ed yesterday, only the hook name is
> changed, its placement in the request cycle is changed and the arguments are a bit
> different.

This doesn't seem to be controversial (a little more flexibility than
what was there before).

But this doesn't do much for my own pet desire for tracing and
instrumenting socket I/O -- keeping standard CORE_IN and CORE_OUT* but
somehow hooking into the APR calls (iols similar to what you suggested
before being the most obvious solution) :(

*fragile beasts^H^H^H^H^H^H^H^H^H^H^H^H^H^Hkey parts of filtering that
 modules shouldn't have to re-implement if at all possible

Jeff Trawick | | PGP public key at web site:
             Born in Roswell... married an alien...

View raw message