httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] fix segfault in core input filter
Date Fri, 11 Jan 2002 19:59:32 GMT
"Bill Stoddard" <bill@wstoddard.com> writes:

> > @@ -260,6 +261,12 @@
> >           */
> >          APR_BRIGADE_INSERT_HEAD(bb, e);
> >          ap_pass_brigade(r->connection->output_filters, bb);
> > +        if (rv != APR_SUCCESS) {
> > +            /* We got an error earlier reading from the socket.  Make sure
> > +             * keepalive is off so that we don't try to read another request.
> > +             */
> > +            r->connection->keepalive = 0;
> > +        }
> >      }
> >  }
> >  
> 
> Should we set r->connection->aborted here?

no, because that disables lingering close...  we just need to know not
to bother trying to read more requests from the socket, and clearing
keepalive does that

but I'm working on a simpler patch now anyway which handles both of
the paths I found where APR_EOF was getting lost

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message