httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Holsman <i...@apache.org>
Subject Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c
Date Wed, 30 Jan 2002 18:31:32 GMT
Jeff Trawick wrote:
> ianh@apache.org writes:
> 
> 
>>ianh        02/01/30 10:05:26
>>
>>  Modified:    modules/experimental mod_cache.c
>>  Log:
>>  out damn warnings out
>>  
>>  Index: mod_cache.c
>>  ===================================================================
>>  RCS file: /home/cvs/httpd-2.0/modules/experimental/mod_cache.c,v
>>  retrieving revision 1.19
>>  retrieving revision 1.20
>>  diff -u -r1.19 -r1.20
>>  --- mod_cache.c	25 Jan 2002 20:09:33 -0000	1.19
>>  +++ mod_cache.c	30 Jan 2002 18:05:26 -0000	1.20
>>  @@ -63,6 +63,10 @@
>>   module AP_MODULE_DECLARE_DATA cache_module;
>>   
>>   
>>  +int ap_url_cache_handler(request_rec *r);
>>  +int ap_cache_out_filter(ap_filter_t *f, apr_bucket_brigade *bb);
>>  +int ap_cache_conditional_filter(ap_filter_t *f, apr_bucket_brigade *in);
>>  +int ap_cache_in_filter(ap_filter_t *f, apr_bucket_brigade *in);
>>
> 
> I started to work on the warnings too, but I don't know what the real
> fix is.  It seems to me that exactly one of the following has to be done:
> 
> 1) make them static (and for extra credit drop the "ap_" prefix)
> 2) put the declarations in a header file
> 
> 

yep..
your right.. these should be static.
fix it in a second.


Mime
View raw message