httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: cvs commit: apache-1.3/src/os/cygwin os.h
Date Thu, 17 Jan 2002 13:42:17 GMT
Oops... I guess I didn't see that veto. Sorry 'bout that.

Do you prefer that I back out that whole section (since the addition
of the pthread mutex must be disabled if we back out just the below)
or keep this, with the understanding that if it's not addressed
within X days, we back it out then?

Jeff Trawick wrote:
> 
> jim@apache.org writes:
> 
> >   Index: http_main.c
> >   ===================================================================
> >   RCS file: /home/cvs/apache-1.3/src/main/http_main.c,v
> >   retrieving revision 1.569
> >   retrieving revision 1.570
> >   diff -u -r1.569 -r1.570
> >   --- http_main.c	16 Jan 2002 19:36:23 -0000	1.569
> >   +++ http_main.c	17 Jan 2002 13:20:51 -0000	1.570
> >   @@ -662,11 +662,16 @@
> >    	perror("pthread_mutexattr_init");
> >    	exit(APEXIT_INIT);
> >        }
> >   +#if !defined(CYGWIN)
> >   +    /* Cygwin has problems with this pthread call claiming that these 
> >   +     * are "Invalid arguements", Stipe Tolj <tolj@wapme-systems.de>
> >   +     */
> >        if ((errno = pthread_mutexattr_setpshared(&mattr,
> >    						PTHREAD_PROCESS_SHARED))) {
> >    	perror("pthread_mutexattr_setpshared");
> >    	exit(APEXIT_INIT);
> >        }
> >   +#endif
> 
> Isn't this what I veto-ed yesterday until Stipe can answer a question
> I had?  (answer: "yes")  I thought I made a very simple, fair request.
> See the message <m3ofjuw49l.fsf@rdu163-40-092.nc.rr.com>.
> 
> The answer to my question needs to be clarified in the comments.
> Spell-checking would be nice too, though I wouldn't consider that a
> requirement for removing the veto :)
> 
> -- 
> Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
>        http://www.geocities.com/SiliconValley/Park/9289/
>              Born in Roswell... married an alien...
> 


-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
      "A society that will trade a little liberty for a little order
                   will lose both and deserve neither"

Mime
View raw message