httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: Running Apache in the foreground
Date Tue, 15 Jan 2002 07:15:14 GMT
On Sun, Jan 13, 2002 at 01:38:56PM -0801, Jos Backus wrote:
> Based on Michael Handler's feedback, here's another patch which simply fixes
> -DNO_DETACH to dtrt. This way things are under operator control and we avoid
> people running httpd under non-job-control shells shooting themselves in the
> foot.
> 
> Please let me know if there's anything that prevents this patch from being
> incorporated so I can fix it. Thanks!

As a rule, please don't do style changes in a patch that changes
functionality.  It makes it too hard to review what you have really
changed.

> @@ -1433,9 +1433,8 @@
>  
>      debug = ap_exists_config_define("DEBUG");
>  
> -    if (debug) {
> +    if (debug)
>          no_detach = one_process = 1;
> -    }
>      else {
>          one_process = ap_exists_config_define("ONE_PROCESS");
>          no_detach = ap_exists_config_define("NO_DETACH");

This and others like it is a no-no.  The current style is correct
(brace even if one-line) - we do this to make it easier when
people add a line to a conditional clause.  (I learned this the
hard way, too...)

Please remove any unnecessary style changes and resubmit your patch.
Thanks.  -- justin


Mime
View raw message