httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@Fujitsu-Siemens.com>
Subject Re: [PATCH] 1.3: further Cygwin platform support
Date Tue, 08 Jan 2002 11:09:28 GMT
On Wed, Jan 02, 2002 at 12:42:01PM +0100, Stipe Tolj wrote:
> diff -ur apache-1.3/src/helpers/install.sh apache-1.3-cygwin/src/helpers/install.sh
> --- apache-1.3/src/helpers/install.sh	Tue Jun 12 10:24:54 2001
> +++ apache-1.3-cygwin/src/helpers/install.sh	Sat Nov 10 17:07:48 2001
> @@ -88,13 +88,9 @@
>  fi
>  
>  #  Check if we need to add an executable extension (such as ".exe") 
> -#  on specific OS to src and dst
> -if [ -f "$src.exe" ]; then
> -  if [ -f "$src" ]; then
> -    : # Cygwin [ test ] is too stupid to do [ -f "$src.exe" ] && [ ! -f "$src"
]
> -  else
> -    ext=".exe"
> -  fi
> +#  on specific OS to src and dst.
> +if [ -f "$src.exe" ] && [ ! -f "$src." ] then
> +  ext=".exe"
>  fi
>  src="$src$ext"
>  dst="$dst$ext"

Sorry to be picky here.... (Slowly, you're beginning to convince
me that the extra test for "! -f $src" is not worth the trouble
of fighting against cygwin's stupidity)...

Testing for [ ! -f "$src." ] is not the same thing
as testing for [ ! -f "$src" ].

And it is the latter which I was worried about:
what happens if -on a unix platform- I happen
to have a $src.exe in my directory? Yes, Apache will assume
that my platform uses the .exe extension. And it will break.

But if it breaks on Cygwin, I am much less worried that when
it breaks on unix, to be honest. So IMHO, it is cygwin that
should be fixed so that it will allow us to make such a test.

   Martin
-- 
<Martin.Kraemer@Fujitsu-Siemens.com>         |     Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730  Munich,  Germany

Mime
View raw message