httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: cvs commit: apache-1.3/src/include http_protocol.h
Date Mon, 21 Jan 2002 20:36:00 GMT
> wrowe       02/01/21 12:29:12
>   Modified:    src/include http_protocol.h
>   Log:
>     ap_rprintf is implemented as API_EXPORT() in http_protocol.c.
>     Therefore, make the prototype and implementation consistant.
>     The question remains, why no compiler warning/emit?  Because MSVC [my
>     version, at least] must have changed all of the ap_fn(foo, ...) decl
>     from _stdcall to _cdecl, on it's own!
>     I suggest our declarations are still borked, but they have worked only
>     because MSVC ignored our poor judgement :)

I just proved this theory to myself by reapplying the .c patches without
reapplying the .h patches to make these fns _NONSTD.  No warning.  Changing
the return type for one of the ap_rprintf() declarations caused a prototype
mismatch warning - so we know the http_protocol.c really is reading the .h

I could commit the correct fixes or leave them alone.  I don't care at this


View raw message