httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject Re: cvs commit: apache-1.3/src/main http_core.c
Date Wed, 09 Jan 2002 21:53:55 GMT
I question whether this chaged required a MMN major bump.  A semi-public structure was
extended (new field added to the end) which should not require a bump in the major.

Bill

----- Original Message -----
From: "Roy T. Fielding" <fielding@ebuilt.com>
To: <dev@httpd.apache.org>
Sent: Wednesday, January 09, 2002 4:38 PM
Subject: Re: cvs commit: apache-1.3/src/main http_core.c


> -1.  If this change required a MMN bump, it should never have been made
> to the 1.3 branch.  That branch is done.
>
> ....Roy
>
>
> On Wed, Jan 09, 2002 at 07:47:03PM -0000, coar@apache.org wrote:
> > coar        02/01/09 11:47:03
> >
> >   Modified:    src/include ap_mmn.h
> >                src/main http_core.c
> >   Log:
> >   Whoops, forgot to bump MMN.  Major bump because of a change
> >   to the semi-private core_dir_config structure.  (Also fix a
> >   stale comment from an earlier version of the FileETag patch.)
> >
> >   Revision  Changes    Path
> >   1.56      +4 -2      apache-1.3/src/include/ap_mmn.h
> >
> >   Index: ap_mmn.h
> >   ===================================================================
> >   RCS file: /home/cvs/apache-1.3/src/include/ap_mmn.h,v
> >   retrieving revision 1.55
> >   retrieving revision 1.56
> >   diff -u -u -r1.55 -r1.56
> >   --- ap_mmn.h 30 Nov 2001 14:08:43 -0000 1.55
> >   +++ ap_mmn.h 9 Jan 2002 19:47:03 -0000 1.56
> >   @@ -233,14 +233,16 @@
> >     * 19990320.10          - add ap_is_rdirectory() and ap_stripprefix()
> >     * 20011130.11          - Add a couple of fields, callback_data and
> >     *                        filter_callback to the end of buff.h
> >   + * 20020108.0           - Add some fields to the end of the core_dir_config
> >   + *                        structure
> >     */
> >
> >    #define MODULE_MAGIC_COOKIE 0x41503133UL /* "AP13" */
> >
> >    #ifndef MODULE_MAGIC_NUMBER_MAJOR
> >   -#define MODULE_MAGIC_NUMBER_MAJOR 19990320
> >   +#define MODULE_MAGIC_NUMBER_MAJOR 20020108
> >    #endif
> >   -#define MODULE_MAGIC_NUMBER_MINOR 11                    /* 0...n */
> >   +#define MODULE_MAGIC_NUMBER_MINOR 0                     /* 0...n */
> >
> >    /* Useful for testing for features. */
> >    #define AP_MODULE_MAGIC_AT_LEAST(major,minor) \
> >
> >
> >
> >   1.302     +1 -1      apache-1.3/src/main/http_core.c
> >
> >   Index: http_core.c
> >   ===================================================================
> >   RCS file: /home/cvs/apache-1.3/src/main/http_core.c,v
> >   retrieving revision 1.301
> >   retrieving revision 1.302
> >   diff -u -u -r1.301 -r1.302
> >   --- http_core.c 5 Jan 2002 17:13:02 -0000 1.301
> >   +++ http_core.c 9 Jan 2002 19:47:03 -0000 1.302
> >   @@ -3013,7 +3013,7 @@
> >    #endif /* CHARSET_EBCDIC */
> >
> >    /*
> >   - * Note whether file inodes may be used when forming ETag values.
> >   + * Note what data should be used when forming file ETag values.
> >     * It would be nicer to do this as an ITERATE, but then we couldn't
> >     * remember the +/- state properly.
> >     */
> >
> >
> >
>


Mime
View raw message