httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject Re: cvs commit: httpd-2.0/server core.c
Date Thu, 03 Jan 2002 19:39:46 GMT

> On Thu, Jan 03, 2002 at 02:31:49PM -0500, Bill Stoddard wrote:
> > I've spent some time on this and this is one reason I am sort of interested in a
proxy
> > specific input filter.  I agree with Ryan that 99.9% would be identical to what
is
already
> > in HTTP_IN now.
>
> Then, why have a separate input filter just for proxy?  IIRC, proxy
> could use some work to play nicer with filters, but I don't think
> we need to duplicate the code.  My $.02.  Either we do checks like
> you added or split it out (which I don't think is worth doing just
> for limits).  -- justin
>

I voted with a commit :-) I agree with you on all points. Just a little nervous about
other filters being inserted into the input stream that frob stuff in the request_rec that
is not initialized by ap_proxy_make_fake_req(). In practice, it is probably not a problem
though.

Bill


Mime
View raw message