Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 96574 invoked by uid 500); 4 Dec 2001 21:42:47 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 96561 invoked from network); 4 Dec 2001 21:42:46 -0000 Sender: gregames@Mail.MeepZor.Com Message-ID: <3C0D434F.CC422DA2@remulak.net> Date: Tue, 04 Dec 2001 16:42:39 -0500 From: Greg Ames X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.19-10mdk i686) X-Accept-Language: en MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: cvs commit: httpd-2.0/server protocol.c References: <20011202231112.68694.qmail@icarus.apache.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N brianp@apache.org wrote: > +AP_DECLARE(int) ap_rgetline(char **s, int n, request_rec *r, int fold) > - last_char = pos + length - 1; > - if (last_char < beyond_buff) { > + if (length - 1 < n) { how do we keep track of buffer overrun conditions when there are multiple reads? unlikely, I know, but... Greg