httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/netware mpm_netware.c
Date Tue, 18 Dec 2001 16:31:56 GMT
"Brad Nicholes" <BNICHOLES@novell.com> writes:

> Jeff,
>      I think that the mistake I made here was not changing the error
> message text.  I had changed HARD_SERVER_LIMIT to HARD_THREAD_LIMIT on
> purpose because NetWare does not have processes.  Therefore we will
> never have more than one server anyway and in fact the NetWare MPM does
> not even provide a way for the user to change MAX_SERVERS because it
> doesn't make sense for us.  Is there any reason why you changed this to
> HARD_SERVER_LIMIT other than it didn't seem to make sense with the
> message text?  If not, I will go ahead and change it back with the
> appropriate message text.

My changes were HARD_SERVER_LIMIT->HARD_THREAD_LIMIT too.  I had found
a couple more places where we that change was necessary.

I did wonder if the message text should be changed too but wasn't sure
and didn't tweak.

>   Index: mpm_netware.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/server/mpm/netware/mpm_netware.c,v
>   retrieving revision 1.16
>   retrieving revision 1.17
>   diff -u -r1.16 -r1.17
>   --- mpm_netware.c	2001/12/18 13:48:53	1.16
>   +++ mpm_netware.c	2001/12/18 14:18:28	1.17
>   @@ -1131,12 +1131,12 @@
>        if (ap_threads_limit > HARD_THREAD_LIMIT) {
>           ap_log_error(APLOG_MARK, APLOG_STARTUP | APLOG_NOERRNO, 0,
> NULL, 
>                        "WARNING: MaxClients of %d exceeds compile time
> limit "
>   -                    "of %d servers,", ap_threads_limit,
> HARD_SERVER_LIMIT);
>   +                    "of %d servers,", ap_threads_limit,
> HARD_THREAD_LIMIT);

Here I simply changed HARD_SERVER_LIMIT to HARD_THREAD_LIMIT.  That
seems right to me :)

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message