httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] Bypass ap_run_process_connection...
Date Sat, 22 Dec 2001 13:00:54 GMT
"Bill Stoddard" <bill@wstoddard.com> writes:

> If the pre_connection hook detects the connection has gone away. I notice that mod_ssl
can
> detect aborted connections in the preconnection hook. Seems a good idea to make a check
> here and just skip ap_run_process_connection is the connection is gone.

like this code?

    if ((ssl = SSL_new(sc->pSSLCtx)) == NULL) {
        ssl_log(c->base_server, SSL_LOG_ERROR|SSL_ADD_SSLERR,
                "Unable to create a new SSL connection from the SSL context");
        c->aborted = 1;
        return DECLINED; /* XXX */
    } 

I guess that "DECLINED; /* XXX */" was an act of frustration that the
core code didn't look at c->aborted and there was nothing that could
be returned to cause the core code to skip further processing?

Your patch seems like a reasonable fix.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message