httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: [PATCH] mod_proxy truncates status line
Date Sun, 30 Dec 2001 12:58:16 GMT
Adam Sussman wrote:

> Mod_proxy truncates the status line returned by the proxied
> server.  One character gets snipped off of the end of the
> status line.

Are you 100% sure the buffer is big enough to do this? If the buffer is
of size "len" the zero will be written past the end of the buffer.

> Index: modules/proxy/proxy_http.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/modules/proxy/proxy_http.c,v
> retrieving revision 1.114
> diff -u -r1.114 proxy_http.c
> --- proxy_http.c        19 Dec 2001 16:32:01 -0000      1.114
> +++ proxy_http.c        29 Dec 2001 00:12:21 -0000
> @@ -689,7 +689,7 @@
>                              "server: ", buffer, NULL));
>              }
>              backasswards = 0;
> -            buffer[--len] = '\0';
> +            buffer[len] = '\0';
> 
>              buffer[12] = '\0';
>              r->status = atoi(&buffer[9]);

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."
Mime
View raw message