httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <brian.p...@cnet.com>
Subject Re: [PATCH] Re: f->c and f->r->connection
Date Fri, 28 Dec 2001 19:44:45 GMT
Justin Erenkrantz wrote:

>On Thu, Dec 27, 2001 at 11:07:22PM -0500, Cliff Woolley wrote:
>
>>Why are there some circumstances when f->c is NULL but f->r and
>>f->r->connection are valid?  I could understand f->r being NULL while f->c
>>would not be, but the other way around took me totally by surprise.
>>
>
>I agree.  I wonder if this patch would break anything.  It seems
>sane.  -- justin
>
>Index: server/util_filter.c
>===================================================================
>RCS file: /home/cvs/httpd-2.0/server/util_filter.c,v
>retrieving revision 1.73
>diff -u -r1.73 util_filter.c
>--- server/util_filter.c	2001/12/28 05:46:21	1.73
>+++ server/util_filter.c	2001/12/28 05:49:22
>@@ -277,7 +277,7 @@
>             f->frec = node->frec;
>             f->ctx = ctx;
>             f->r = r;
>-            f->c = c;
>+            f->c = r ? r->connection : c;
> 
>             if (INSERT_BEFORE(f, *outf)) {
>                 f->next = *outf;
>

+1

--Brian




Mime
View raw message