httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: cvs commit: httpd-2.0/server protocol.c
Date Wed, 05 Dec 2001 01:35:05 GMT
Greg Ames wrote:

>brianp@apache.org wrote:
>
>>  +AP_DECLARE(int) ap_rgetline(char **s, int n, request_rec *r, int fold)
>>
>
>>  -        last_char = pos + length - 1;
>>  -        if (last_char < beyond_buff) {
>>  +        if (length - 1 < n) {
>>
>
>how do we keep track of buffer overrun conditions when there are
>multiple reads?  unlikely, I know, but...
>

Thanks for catching that...the new check only works properly on the
first read, where the invariant beyond_buff==pos+n is still true.
I'll fix it in a minute.

--Brian



Mime
View raw message