httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harrie Hazewinkel <>
Subject Re: [PATCH] a type mismatch correction (signed/unsigned)
Date Sun, 16 Dec 2001 20:41:52 GMT

--On Sunday, December 16, 2001 10:52 AM -0500 Jeff Trawick 
<> wrote:

> Harrie Hazewinkel <> writes:
>> The attached patch fixes a type mismatch discovered on
>> win32.
> I don't think ap_getline() and ap_rgetline() should have different
> types for the buffer-size parameter.
> What is the type mismatch, anyway?

a type mismatch between a signed int which is in the function
parameter list and its usage where is is compared to
unsigned int (apr_size_t).

And I agree that actually ap_getline() and ap_rgetline()
should have the same type for buffer size. I would even extend
it to everywhere a buffer size is used in Apache one
should use apr_size_t.


View raw message