httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: cvs commit: httpd-2.0/modules/filters mod_include.c
Date Fri, 28 Dec 2001 17:52:27 GMT
> wrowe       01/12/28 09:44:28
>   Modified:    modules/filters mod_include.c
>   Log:
>     Improvements suggested by Brian Pane, first assure all OS's get to deal
>     with handler 'server-parsed', do the xbithack bit tests before testing
>     it's string values (protected against a null point).
>     And make it [perhaps] more legible.

Thanks Brian... this code has been gathering much dust, it's more useful
if the world can evaluate it, rather than my pouring over it any further.
The negotation code needs a final vetting [this afternoon?  I hope!] before
it's committed, and then reviewed for completeness [Allows 'prefered' handling
independently for both MULTIPLE_CHOICES and NONE_ACCEPTABLE.)
Then, off into the MPM again.

Oh, there was no trivially legible way, that I saw, to run the xbithack checks
before the handler test, and I suspect that we needed to fix the handler always,
irrespective of everything else.  Since I suspect fewer users actually use xbit,
this makes sense to me.


View raw message