httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: [PATCH] Eliminate HARD_THREAD_LIMIT on Windows
Date Sat, 22 Dec 2001 17:31:24 GMT
From: "Jeff Trawick" <trawick@attglobal.net>
Sent: Saturday, December 22, 2001 6:57 AM


> "Bill Stoddard" <bill@wstoddard.com> writes:
> 
> > So I says to myself, "self, why introduce the ThreadLimit directive when the scoreboard
on
> > Windows is not shared between processes, ever?". So here is a patch: the scoreboard
is
> > always allocated to be exactly big enough for ThreadsPerChild entries. And it can
grow or
> > shrink across restarts because the scoreboard is never shared across processes.
Why didn't
> > I think o this sooner? It's late so posting a patch rather than committing code...
> 
> it makes sense to me, but what do I know about the NT MPM?  (answer:
> almost nothing)... but it either works or it doesn't, so commit it
> already if it does

No... thanks for taking the time to post the patch, Bill!  Since it would
interfere with moving the WinNT port twords a more scaleable solution, I'm
glad to have a chance to comment, instead of asking for the code to be
reverted.

On your other [earlier] always-single-process patch, it's just as well 
that we simplified the MPM first, so that making the code more APR-based 
[first!] became a more trivial task :)

Bill


Mime
View raw message