Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 55128 invoked by uid 500); 21 Nov 2001 16:41:46 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 55117 invoked from network); 21 Nov 2001 16:41:45 -0000 X-Authentication-Warning: rdu163-40-092.nc.rr.com: trawick set sender to trawick@attglobal.net using -f Sender: trawick@rdu163-40-092.nc.rr.com To: jfrederic.clere@fujitsu-siemens.com Cc: new-httpd Subject: Re: [PATCH] Check the mpm exists when using --with-mpm=MPM References: <3BFBC500.F86B65D8@fujitsu-siemens.com> <3BFBD627.CFA313F5@fujitsu-siemens.com> From: Jeff Trawick Date: 21 Nov 2001 11:40:56 -0500 In-Reply-To: <3BFBD627.CFA313F5@fujitsu-siemens.com> Message-ID: Lines: 28 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N jean-frederic clere writes: > =================================================================== > RCS file: /home/cvs/apache/httpd-2.0/server/mpm/config.m4,v > retrieving revision 1.39 > diff -u -r1.39 config.m4 > --- ./server/mpm/config.m4 2001/11/19 18:07:28 1.39 > +++ ./server/mpm/config.m4 2001/11/21 16:24:35 > @@ -22,6 +22,9 @@ > apache_cv_mpm=prefork > fi > fi > +if test ! -f "server/mpm/$apache_cv_mpm/mpm.h"; then > + AC_MSG_ERROR(the selected mpm: $apache_cv_mpm is not supported) > +fi > > APACHE_FAST_OUTPUT(server/mpm/Makefile) > don't we need an "exit 1" in there? otherwise, the user may miss the message and still get way into make where mpm_common.c (just a guess) won't compile because it can't find mpm.h (maybe AC_MSG_ERROR() bails out; I dunno) -- Jeff Trawick | trawick@attglobal.net | PGP public key at web site: http://www.geocities.com/SiliconValley/Park/9289/ Born in Roswell... married an alien...