Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 73216 invoked by uid 500); 21 Nov 2001 02:36:17 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 73205 invoked from network); 21 Nov 2001 02:36:16 -0000 X-Authentication-Warning: localhost.localdomain: sterling owned process doing -bs Date: Tue, 20 Nov 2001 19:37:03 -0800 (PST) From: sterling X-X-Sender: To: Subject: [PATCH] apache core dumps if you call ap_note_basic_auth_failure when auth type is null Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Hi - Set up an auth directory without AuthType but with require valid-user and AuthName and load an auth module that uses ap_note_basic_auth_failure... el kabong!! this patch stops the coro dumpo. sterling Index: server/protocol.c =================================================================== RCS file: /home/cvspublic/httpd-2.0/server/protocol.c,v retrieving revision 1.52 diff -u -r1.52 protocol.c --- server/protocol.c 2001/11/12 23:49:06 1.52 +++ server/protocol.c 2001/11/21 02:14:43 @@ -764,7 +764,7 @@ AP_DECLARE(void) ap_note_basic_auth_failure(request_rec *r) { - if (strcasecmp(ap_auth_type(r), "Basic")) + if( ap_auth_type(r) && strcasecmp(ap_auth_type(r), "Basic")) ap_note_auth_failure(r); else apr_table_setn(r->err_headers_out,