Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Content-Type: text/plain;
  charset="iso-8859-1"
From: Ryan Bloom <rbb@covalent.net>
Reply-To: rbb@covalent.net
Organization: Covalent Technologies
To: dev@httpd.apache.org, Brian Pane <bpane@pacbell.net>
Subject: Re: [PATCH] performance fix for mod_include
Date: Sat, 10 Nov 2001 13:12:50 -0800
Cc: dev@httpd.apache.org
References: <Pine.GSO.4.32.0111101330500.12831-100000@cobra.cs.Virginia.EDU>
 <3BED936D.50405@pacbell.net> <20011110210324.8809B46DFD@koj.rkbloom.net>
In-Reply-To: <20011110210324.8809B46DFD@koj.rkbloom.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <20011110211250.5E7DB46DFD@koj.rkbloom.net>

On Saturday 10 November 2001 01:03 pm, Ryan Bloom wrote:
> On Saturday 10 November 2001 12:51 pm, Brian Pane wrote:
> > Ryan Bloom wrote:
> > [...]
> >
> > >>Later today I'll post a new patch that turns error_str and time_str
> > >>into char*.
> > >
> > >Just remove them from the structure all together.  They aren't necessary
> > >in that structure.
> >
> > Where else would you put them?  If they move out of the filter
> > context struct, they'll have to move someplace where they're
> > still accessible by the filter in subrequests (to handle the
> > case of shtml files included within other shtml files).
>
> All we do with them is copy them into the filter context structure.  Then> we use that copy when we parse the string.  But, parsing is a
> non-destructive operation.  So, we can get rid of them from the structure,
> and just use the copies in the directory structure.
>
> Ryan

Damn, I counted the arguments to ap_parse_ssi_string incorrectly.  I still
think we can get rid of those strings, but I need to look at the code a bit
closer.

Ryan

______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------