Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Wed, 7 Nov 2001 01:56:30 -0800
From: Greg Stein <gstein@lyra.org>
To: dev@httpd.apache.org
Cc: wrowe@apache.org
Subject: Re: cvs commit: httpd-2.0/server protocol.c
Message-ID: <20011107015630.D18942@lyra.org>
References: <20011107054122.71529.qmail@icarus.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20011107054122.71529.qmail@icarus.apache.org>;
 from dougm@apache.org on Wed, Nov 07, 2001 at 05:41:22AM -0000

Um. That doesn't look right.

Those macros are based on *linkage*, not usage. If server/protocol.c occurs
within the "core" DLL on Windows, then it must use the AP_CORE_DECLARE()
macro.

Those macros have nothing to do with visibility, and everything to do with
linkage.

OtherBill knows the most here, so let's hear his opinion here. I only
/think/ something may be wrong here.

Cheers,
-g

On Wed, Nov 07, 2001 at 05:41:22AM -0000, dougm@apache.org wrote:
> dougm       01/11/06 21:41:22
> 
>   Modified:    include  http_protocol.h
>                server   protocol.c
>   Log:
>   ap_getline() is useful to modules outside of the core..
>   change declaration from AP_CORE_DECLARE to AP_DECLARE so it can be used
>   used outside the core
>   
>   Revision  Changes    Path
>   1.66      +1 -1      httpd-2.0/include/http_protocol.h
>   
>   Index: http_protocol.h
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/include/http_protocol.h,v
>   retrieving revision 1.65
>   retrieving revision 1.66
>   diff -u -r1.65 -r1.66
>   --- http_protocol.h	2001/09/28 13:48:43	1.65
>   +++ http_protocol.h	2001/11/07 05:41:22	1.66
>   @@ -526,7 +526,7 @@
>     */
>    AP_CORE_DECLARE(void) ap_parse_uri(request_rec *r, const char *uri);
>    
>   -AP_CORE_DECLARE(int) ap_getline(char *s, int n, request_rec *r, int fold);
>   +AP_DECLARE(int) ap_getline(char *s, int n, request_rec *r, int fold);
>    
>    /**
>     * Get the method number associated with the given string, assumed to
>   
>   
>   
>   1.51      +1 -1      httpd-2.0/server/protocol.c
>   
>   Index: protocol.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/server/protocol.c,v
>   retrieving revision 1.50
>   retrieving revision 1.51
>   diff -u -r1.50 -r1.51
>   --- protocol.c	2001/10/31 21:14:23	1.50
>   +++ protocol.c	2001/11/07 05:41:22	1.51
>   @@ -198,7 +198,7 @@
>     *        If no LF is detected on the last line due to a dropped connection 
>     *        or a full buffer, that's considered an error.
>     */
>   -AP_CORE_DECLARE(int) ap_getline(char *s, int n, request_rec *r, int fold)
>   +AP_DECLARE(int) ap_getline(char *s, int n, request_rec *r, int fold)
>    {
>        char *pos = s;
>        char *last_char;
>   
>   
>   

-- 
Greg Stein, http://www.lyra.org/