httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sterling <sterl...@covalent.net>
Subject [PATCH] apache core dumps if you call ap_note_basic_auth_failure when auth type is null
Date Wed, 21 Nov 2001 03:37:03 GMT
Hi -

Set up an auth directory without AuthType but with require valid-user and
AuthName and load an auth module that uses ap_note_basic_auth_failure...
el kabong!! this patch stops the coro dumpo.

sterling

Index: server/protocol.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/server/protocol.c,v
retrieving revision 1.52
diff -u -r1.52 protocol.c
--- server/protocol.c	2001/11/12 23:49:06	1.52
+++ server/protocol.c	2001/11/21 02:14:43
@@ -764,7 +764,7 @@

 AP_DECLARE(void) ap_note_basic_auth_failure(request_rec *r)
 {
-    if (strcasecmp(ap_auth_type(r), "Basic"))
+    if( ap_auth_type(r) && strcasecmp(ap_auth_type(r), "Basic"))
         ap_note_auth_failure(r);
     else
         apr_table_setn(r->err_headers_out,


Mime
View raw message