httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Havard" <bri...@kheldar.apana.org.au>
Subject Re: [PATCH] convert mod_mem_cache's locks to new APR locks
Date Tue, 20 Nov 2001 13:34:49 GMT
On 20 Nov 2001 07:13:04 -0500, Jeff Trawick wrote:

>Aaron Bannert <aaron@clove.org> writes:
>
>> On Sat, Nov 17, 2001 at 03:51:10PM -0500, Jeff Trawick wrote:
>> > > +#include <apr_thread_mutex.h>
>> > 
>> > just curious... why angle brackets instead of quotes?  practically all
>> > includes of apr_foo.h in apache and apr-util use quotes
>> 
>> I never really understood why we're using the #include "" syntax for
>> APR includes, when APR is considered an external support library. Paths
>> to those includes have to be specified in the -I/path option anyway,
>> no? Any particular reason to use quotes instead?
>
>I can't think of a reason in 2001.  I used to use a compiler that was
>very picky about the distinction between "" and <>.  It would only
>look in the compiler installation directories for <> files, but it
>would look in the user-specified search path for "" files.  Thus, I
>get nervous when I see non-system-supplied includes in <>.  But it has
>been some years since I have encountered such a problem, so that
>doesn't seem like a reason to stick with "".
>
>Consistency, on the other hand, ... :)

One important difference is that when generating dependencies with EG gcc
-MM as our make depend does, only #includes using "" are counted. So <>
includes should only refer to fixed system headers.

EG if test.c contains just:

#include <stdio.h>
#include "stdlib.h"

D:\TMP>gcc -MM test.c
test.o: test.c f:\emx\include\stdlib.h

-- 
 ______________________________________________________________________________
 |  Brian Havard                 |  "He is not the messiah!                   |
 |  brianh@kheldar.apana.org.au  |  He's a very naughty boy!" - Life of Brian |
 ------------------------------------------------------------------------------


Mime
View raw message