httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <madhusudan_mathiha...@hp.com>
Subject RE: [PATCH] ssl_scache_dbm
Date Wed, 07 Nov 2001 04:49:25 GMT
I have already ported the SHMHT and SHMCB methods of caching.. I'll post a
patch shortly..  Though SHMCB has it's own memory management techniques (and
doesn't depend on APR_SHMEM), I thought it'd have been better if there was a
complete implementation of APR_SHMEM.. 

Thx
-Madhu


-----Original Message-----
From: Roy T. Fielding [mailto:fielding@ebuilt.com]
Sent: Tuesday, November 06, 2001 8:38 PM
To: dev@httpd.apache.org
Subject: Re: [PATCH] ssl_scache_dbm


On Tue, Nov 06, 2001 at 10:04:13PM -0500, Bill Stoddard wrote:
> This patch corrects a problem where we are using apr_dbm calls
incorrectly.
> WIBNIF we
> passed in request_rec rather than the server_rec on:
> 
> ssl_scache_dbm_retrieve(server_rec *s, UCHAR *id, int idlen)
> 
> This would allow us to close the dbm with a request pool cleanup which
would remove some
> cruftyness from this patch. Also looking for comments on the
(in)appropriate use of
> ssl_mutex calls to serialize access to the dbm.

They are inappropriate.  In fact, the whole thing is inappropriate -- what
is the point in having a butt-slow cache?

+1 on the patch and removing the mutex, but I think a long-term solution
would be based on advisory locks around a shared-memory API (even if the
shared memory was simply backed by apr_dbm).

....Roy

Mime
View raw message