httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfrederic.cl...@fujitsu-siemens.com>
Subject Re: [PATCH] Check the mpm exists when using --with-mpm=MPM
Date Wed, 21 Nov 2001 17:21:04 GMT
Jeff Trawick wrote:
> 
> jean-frederic clere <jfrederic.clere@fujitsu-siemens.com> writes:
> 
> > ===================================================================
> > RCS file: /home/cvs/apache/httpd-2.0/server/mpm/config.m4,v
> > retrieving revision 1.39
> > diff -u -r1.39 config.m4
> > --- ./server/mpm/config.m4    2001/11/19 18:07:28     1.39
> > +++ ./server/mpm/config.m4    2001/11/21 16:24:35
> > @@ -22,6 +22,9 @@
> >      apache_cv_mpm=prefork
> >    fi
> >  fi
> > +if test ! -f "server/mpm/$apache_cv_mpm/mpm.h"; then
> > +    AC_MSG_ERROR(the selected mpm: $apache_cv_mpm is not supported)
> > +fi
> >
> >  APACHE_FAST_OUTPUT(server/mpm/Makefile)
> >
> 
> don't we need an "exit 1" in there?  otherwise, the user may miss the
> message and still get way into make where mpm_common.c (just a guess)
> won't compile because it can't find mpm.h
> 
> (maybe AC_MSG_ERROR() bails out; I dunno)

It does.

> --
> Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
>        http://www.geocities.com/SiliconValley/Park/9289/
>              Born in Roswell... married an alien...

Mime
View raw message