httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [patch] major ssl problem
Date Sat, 24 Nov 2001 05:17:12 GMT
On Fri, Nov 23, 2001 at 03:57:58PM -0800, Doug MacEachern wrote:
> here's a new version of the patch..
> still solves the major problem of filling the pbioWrite memory buffer with
> the same size as the file.  this could also be solved with something like:
> 
> while (len) {
>     len -= SSL_write(smaller buff size);
>     churn_output();
> }
> 
> but using the custom BIO avoids the extra copy that currently happens in
> bbioWrite.  and makes it possible to optimize further based on what is
> best for bucket brigades and the core output filter.

Less copies the better.  

My only question is whether we could end up reading from the bucket 
(i.e. calling bucket_read) if we decide to "setaside" the bucket - this 
should be possible now with Ryan's latest patches to core_output_filter.
So, might we have to implement bucket_read?  -- justin


Mime
View raw message