httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: Gack! Weirdo DAV bug.
Date Fri, 16 Nov 2001 23:30:39 GMT
On Friday 16 November 2001 11:18 am, cmpilato@collab.net wrote:
> Ryan Bloom <rbb@covalent.net> writes:
> > > I'm not sure what the right fix is, having no real knowledge of
> > > httpd's internals.  The options that come to mind are:
> > >
> > > * Have the server NOT register the REPORT request type.
> > >
> > >    But this seems like a bad idea...I assume that code is there for a
> > >    reason, and the comment above it may be all the reason that's
> > >    needed.
> > >
> > > * Remove the sanity check from mod_dav.c
> > >
> > >    We *know* this works (that's how the code is on svn.collab.net
> > >    today), but it means that every unregistered request type coming
> > >    into mod_dav will suffer about 20 strcmp's.  That sucks.  But, I
> > >    can't think of anything else offhand to solve it.
> >
> > Option 3.  :-)  We have APIs to allow you to check the dynamically
> > registered methods.
>
> I'd already thought about this.  But the methods hash is just
> NAME->number mapping.  What would this gain us?  We already have both
> the name and the number in the request structure.  Maybe I'm missing
> something (I hope).

You misunderstood me.  We already have the APIs to do this.  The same way
that you compare against M_INVALID, you could actually check against
REPORT directly.

Ryan

______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message