httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@clove.org>
Subject Re: cvs commit: httpd-2.0/modules/ssl ssl_util.c
Date Fri, 16 Nov 2001 19:34:26 GMT
On Fri, Nov 16, 2001 at 06:28:25PM -0000, aaron@apache.org wrote:
> aaron       01/11/16 10:28:25
> 
>   Modified:    modules/ssl ssl_util.c
>   Log:
>   Conversion from old apr_lock_t to new apr_thread_mutex_t
>   (only converting INTRAPROCESS locks at this time).
>   
>   I don't see how this used to work, which also means I'm not entirely
>   sure if it works now. It really didn't look like it was allocating
>   the correct size before. It compiles and SSL still works in my limited
>   tests, but I'd appreciate a second opinion.
>   
...
>   +static apr_thread_mutex_t **lock_cs;
>   +static long                 lock_count[CRYPTO_NUM_LOCKS];
...
>   +        lock_count[i] = 0;
>   +        /* XXX: Can we remove the lock_count now that apr_thread_mutex_t
>   +         * can support nested (aka recursive) locks? -aaron */
>   +        apr_thread_mutex_create(&(lock_cs[i]), APR_THREAD_MUTEX_DEFAULT, p);

Also, I didn't want to bring this up in the commit log, but it looks to
me that SSL is attempting to support recursive locks. If this is true,
we can remove some complexity here, since apr_thread_mutex_t types
also support recursive (nested) locks. Does anyone wish to comment on
this?

-aaron

Mime
View raw message