httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/worker worker.c
Date Wed, 14 Nov 2001 00:38:22 GMT

> >   --- perchild.c	2001/11/10 18:26:29	1.82
> >   +++ perchild.c	2001/11/12 23:49:07	1.83
> >   @@ -502,7 +502,7 @@
> >            ap_sock_disable_nagle(sock);
> >        }
> >
> >   -    current_conn = ap_new_connection(p, ap_server_conf, sock,
> > conn_id); +    current_conn = ap_run_create_connection(p, ap_server_conf,
> > sock, conn_id);
>
> There is an extra parameter there, but I think it should stay and the rest
> should change :-)

I'm getting to the rest of the comments in this e-mail slowly, but I did the above.
I could go either way, so rather than argue, I just did it.  :-)

> Otherwise... a good move. Can we toss the pre_connection stuff?

Which pre_connection stuff?  All of it, like that entire hook.  Probably.  Doing that
work after the accept makes more sense in my mind.

Ryan
______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message