httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@clove.org>
Subject Re: [PATCH] performance fix for mod_include
Date Sat, 10 Nov 2001 07:25:58 GMT
On Fri, Nov 09, 2001 at 09:20:23PM -0800, Brian Pane wrote:
> In mod_include, we use apr_pcalloc to create an include_ctx_t,
> which consists of about 80 bytes of integer and pointer fields
> and a pair of character buffers used to hold strings.  Each
> of the character buffers is 8KB...
> 
> calloc'ing all this space accounts for about 9% of the total
> usr-mode CPU time in the httpd.
> 
> This patch zero-fills just the integer and pointer fields in
> the structure, plus the first byte of each of the string buffers.
> With the patch, I'm seeing a 19% improvement in SSI throughput
> in informal testing (ab running a single request at a time,
> over the loopback on Linux).

+1 - I have this same pcalloc --> palloc+memset change in my tree, but
not the reduced memset length; that is a novel idea.

-aaron

Mime
View raw message