httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: cvs commit: httpd-2.0/server protocol.c
Date Mon, 12 Nov 2001 23:43:25 GMT
From: "Ryan Morgan" <>
Sent: Monday, November 12, 2001 4:29 PM

> It would be even better if ap_getline would return an apr_status_t rather
> than the number of bytes read.  This would allow callers of ap_getline to
> detect errors like timeouts, etc from within ap_getline.  Currently we just
> return the number of bytes read, or -1 on error.
> The length parameter could be passed into the function and modified like
> is done in apr calls that return data.
> Thoughts anyone?  I could put together a patch if others see this as a
> useful feature.

If used properly, the length saves us a strlen() call, so the existing
prototype is rather useful.

View raw message