httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject [PATCH] Apache Win32 restart (fix loosing keep-alive POST requests across a restart)
Date Sun, 18 Nov 2001 11:09:33 GMT
Bill, 
Check out this patch for the problem with loosing POST requests across a restart. 

Index: http_main.c
===================================================================
RCS file: /home/cvs/apache-1.3/src/main/http_main.c,v
retrieving revision 1.561
diff -u -r1.561 http_main.c
--- http_main.c 2001/11/16 01:32:20 1.561
+++ http_main.c 2001/11/18 10:54:04
@@ -5840,6 +5840,14 @@
      if (!current_conn->keepalive || current_conn->aborted)
   break;
 
+            /* If the server is shutting down, do not allow anymore requests 
+             * to be handled on the keepalive connection. Leave the thread 
+             * alive to drain the job queue. This check is particularly 
+             * important on the threaded server to allow the process to be 
+             * quickly taken down cleanly.
+             */
+            if (allowed_globals.exit_now)
+                break;
      ap_destroy_pool(r->pool);
      (void) ap_update_child_status(child_num, SERVER_BUSY_KEEPALIVE,
            (request_rec *) NULL);
@@ -6203,7 +6211,7 @@
             add_job(csd);
         }
     }
-      
+
     APD2("process PID %d exiting", my_pid);
 
     /* Get ready to shutdown and exit */
@@ -6421,7 +6429,7 @@
      total_jobs++;
  }
     }
-      
+
     APD2("process PID %d exiting", my_pid);
 
     /* Get ready to shutdown and exit */



Mime
View raw message