Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Wed, 10 Oct 2001 23:15:26 -0700
From: Justin Erenkrantz <jerenkrantz@ebuilt.com>
To: dev@httpd.apache.org
Subject: Re: [PATCH] fix unnecessary logic, fix warning, add comment
Message-ID: <20011010231526.T23667@ebuilt.com>
References: <20011011014032.11357.qmail@icarus.apache.org>
 <20011010193617.L7571@clove.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20011010193617.L7571@clove.org>
User-Agent: Mutt/1.3.22.1i

On Wed, Oct 10, 2001 at 07:36:17PM -0700, Aaron Bannert wrote:
> You'll probably want to commit the following patch as well:
> 
> - converts do-while+if to just a while, so we don't call
>     AP_BRIGADE_EMPTY twice per loop.

Yup.  General goodness.

> - fixes a warning (the *readbytes parameter is an apr_off_t for some reason)

Once things settle down, I'd like to kill apr_off_t in the filters
and always use apr_size_t.  It'd make things so much more consistent.

If anyone wants to enlighten me on the origins of apr_off_t in
the filter code, I'd like to know.

> - adds a little comment to the mystery loop (is my comment correct?)

Looks right.  Just remember that ap_get_client_block should be
called in a loop as well.  =)  Loops in loops in loops.  Oh, what
fun.  

So, +1.  I'll let Ryan sort this out since he committed a 
conflicting patch.  -- justin