Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Tue, 9 Oct 2001 10:55:44 -0700
From: Aaron Bannert <aaron@clove.org>
To: dev@httpd.apache.org
Subject: [PATCH] enable mod_so by default [Was: DSO]
Message-ID: <20011009105544.U13476@clove.org>
References: <1002464883000020@lycos.co.uk> <20011007083116.Z13476@clove.org>
 <20011008202124.H21545@ebuilt.com> <m3elod12up.fsf@rdu88-250-106.nc.rr.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <m3elod12up.fsf@rdu88-250-106.nc.rr.com>;
 from trawick@attglobal.net on Tue, Oct 09, 2001 at 07:15:26AM -0400

On Tue, Oct 09, 2001 at 07:15:26AM -0400, Jeff Trawick wrote:
> It sounds reasonable to me to build mod_so by default, but I think
> that the builder should be able to turn off mod_so.
> 
> Somebody putting together a package for distribution/support ought to
> be able to decide what modules they are willing to deal with, and
> mod_so opens up everything.  I doubt that a commercial vendor would
> make such a decision, but certainly within an organization it might
> make sense.  I bet a lot of companies would like a build of IIS to
> put on their employees' machines which could not be made to do
> anything other than serve static pages :)

I think this patch would do that. One should be able to do --disable-so
to turn it off, and by default it will be built.

My only worry is that this will break out-of-the-box builds for platforms
that aren't supported under apr_dso.h. Are any of our apache-supported
platforms not supported under apr_dso.h?

-aaron


Index: modules/mappers/config9.m4
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/mappers/config9.m4,v
retrieving revision 1.5
diff -u -r1.5 config9.m4
--- modules/mappers/config9.m4	2001/10/03 17:47:51	1.5
+++ modules/mappers/config9.m4	2001/10/09 17:48:21
@@ -17,11 +17,8 @@
   APR_ADDTO(CFLAGS,-DNO_DBM_REWRITEMAP)
 ])
 
-if test "$sharedobjs" = "yes"; then
-    APACHE_MODULE(so, DSO capability, , , static)
-else
-    APACHE_MODULE(so, DSO capability, , , no)
-fi
+APACHE_MODULE(so, DSO capability, , , static)
+
 dnl ### why save the cache?
 AC_CACHE_SAVE