Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Mon, 8 Oct 2001 09:27:37 -0700
From: Greg Stein <gstein@lyra.org>
To: Jim Jagielski <jim@jaguNET.com>
Cc: dev@httpd.apache.org
Subject: Re: cvs commit: apache-1.3/src CHANGES Configuration.tmpl Configure
Message-ID: <20011008092736.P4216@lyra.org>
References: <20011008084030.O4216@lyra.org>
 <200110081600.MAA12191@devsys.jaguNET.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <200110081600.MAA12191@devsys.jaguNET.com>;
 from jim@jaguNET.com on Mon, Oct 08, 2001 at 12:00:26PM -0400

On Mon, Oct 08, 2001 at 12:00:26PM -0400, Jim Jagielski wrote:
>...
> Except, of course, that your logic didn't work. What is needed is some
> way to say "use system, use expat-lite or use whichever you find first
> (prefer system)". If we *don't* provide a choice, then why have
> any sort of rule in the 1st place?? If EXPAT 'no' means Don't Use
> expat-lite then that's easy to fix.

RULE_EXPAT is for including expat, not for selecting which one.

The interesting choices, which were coded properly(*) before your change:

* use system if available; otherwise, use builtin
* don't include expat from anywhere
* if available somewhere, then use it; otherwise, skip

These correspond to Yes, No, and Default.

If there is a system expat available, then there is no reason to choose the
builtin one. That is not a required option. The system version is *always*
preferable.

Note that Martin checked in something (accidentally, I presume, based on the
rest of the commit) to this section of code, so reverting your change might
be a bit trickier. But your change does need to be reverted. The previous
code implemented the proper logic.

Cheers,
-g

(*) I did make a tweak post .21 tag which fixed a case where expat-lite was
removed from the source bundle (you had pointed out the typo/logic issue on
that one), but the code always implemented the right set of choices

-- 
Greg Stein, http://www.lyra.org/