Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Mon, 1 Oct 2001 02:20:38 -0700
From: Greg Stein <gstein@lyra.org>
To: dev@httpd.apache.org
Subject: Re: cvs commit: httpd-2.0/server protocol.c
Message-ID: <20011001022038.F24132@lyra.org>
References: <20010929084859.91537.qmail@icarus.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20010929084859.91537.qmail@icarus.apache.org>;
 from jerenkrantz@apache.org on Sat, Sep 29, 2001 at 08:48:59AM -0000

On Sat, Sep 29, 2001 at 08:48:59AM -0000, jerenkrantz@apache.org wrote:
> jerenkrantz    01/09/29 01:48:59
> 
>   Modified:    modules/http http_core.c http_protocol.c
>                server   protocol.c
>   Log:
>   Remove the lameo create_req hack and delay the addition of the HTTP_IN
>   filter until after we have read the headers.  This eliminates the status
>   hack that was in http_protocol.c and makes it all around better.
>   
>   server/protocol.c now directly adds HTTP_IN filter - should we create a
>   specific hook for this?  (Could we do this as a post_read_request hook?)
>   I'm not terribly sure, but let's move it down to the lowest possible
>   place in ap_read_request.  We can change this detail later as we see fit.

Don't worry about it. As long as protocol.c deals with HTTP (specifically,
it manages the reading of the headers, among many other things), then there
isn't a problem with adding the HTTP_IN filter.

If somebody wants to make protocol.c "pure", then they're going to have a
lot more to worry about than the HTTP_IN thing.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/