httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <>
Subject RE: [PATCH] mod_ssl input filtering...
Date Sat, 06 Oct 2001 17:12:13 GMT

-----Original Message-----
From: Greg Stein []
Sent: Saturday, October 06, 2001 9:14 AM

>On Sat, Oct 06, 2001 at 04:41:50AM -0400, MATHIHALLI,MADHUSUDAN
(HP-Cupertino,ex1) wrote:
>> Hi,
>> 	The new patch seems to be the way to go - but I think there's way
>> too much overhead here :-(..  I still haven't been able to review/test
>> patch (as i'm totally swamped with my school work)..
>Those two statements are contradictory. How can you know about the overhead
>if you haven't reviewed the patch?

I was probably not clear.. The first stmt is my reaction when I browsed
thru' the code - I did not *review* the code.. Browsing and reviewing the
code are two seperate activities to me.

>> A cursory look of the code suggests that we're trying to overdo the
>> churn_input activity here (it's probably justified) - but I'm sure it's
>> definitely going to adversely affect the SSL performance.. I think it's
>> something which is to be kept in mind before the design is complete..
>> I'll probably post my comments on the new patch by tommorow.
>How about if we get mod_ssl working before worrying about the performance?

SURE.. 'getting mod_ssl to work is definitely the top priority - but what I
meant to say was that performance is something which cannot be ignored
during the design. 


View raw message