httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <>
Subject [PATCH] performance improvement for userdata
Date Sat, 27 Oct 2001 19:46:58 GMT
[This is a repost of an uncommitted patch from a week or two ago.
I've updated the patch to work against the current code base in CVS.]

Two small improvements for apr_pool_userdata_set():
* A "setn" variant that doesn't strdup the key (useful when,
 for example, the key is a compile-time constant)
* Support for passing in NULL as the cleanup callback, so
 that items that don't require a cleanup need not incur
 the overhead of registering a no-op callback.

The patch includes changes for Apache's request.c and
mod_log_config to take advantage of these features.
The change to request.c is significant because the
caching code in directory_walk and location_walk uses
the userdata API quite a bit (and with really long key
names, so that eliminating the strdups is a win).


View raw message