httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <grega...@remulak.net>
Subject Re: cvs commit: httpd-2.0/server request.c
Date Tue, 16 Oct 2001 20:23:30 GMT
wrowe@apache.org wrote:
> 
> wrowe       01/10/15 19:19:42
> 
>   Modified:    server   request.c
>   Log:
>     directory_walk trounced existing path_info declarations.  I suspect _this_
>     was Greg Ames bug...

>   --- request.c 2001/10/16 02:15:45     1.72
>   +++ request.c 2001/10/16 02:19:42     1.73
>   @@ -543,7 +543,11 @@
>            opts_remove = this_dir->opts_remove;
>            override = this_dir->override;
> 
>   -        r->path_info = r->filename;
>   +        /* XXX: Remerge path_info, or we are broken.  Needs more thought.
>   +         */
>   +        if (r->path_info)
>   +            r->path_info = ap_make_full_path(r->pool, r->filename,
>   +                                                      r->path_info);

r->path_info definately has something to do with it.  

I just stepped thru handle_map_file & read_types_multi with yesterday
morning's cvs, using our default /manual/ URI.  It finds the three
language variants for index.html in that dir, and in my case picks
index.html.en as best.  So far, so good.

At the very end of handle_map_file, it grabs r->path_info which is an
empty string, massages it some yielding "/", concatenates the result
with the "best" file name from the /manual/ directory (index.html.en)
plus r->path_info once more (???) and does an internal redirect to
/index.html.en .  bzzzzzzt - we just lost the /manual/ piece of the URI.

I'll cvs up to pick up this change, put my patch back on, & see what
happens.

Greg

Mime
View raw message