httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stipe Tolj <t...@wapme-systems.de>
Subject Re: [PATCH] 1.3: fix for broken binbuild.sh on Cygwin 1.x platform
Date Thu, 11 Oct 2001 15:29:31 GMT
> Please send the attachments as "text/plain", not as
> "application/x-unknown-content-type-diff_auto_file".

sorry, Nescape seems to be bogus here.

> Also, for me this is a "-1".

it ain't a major problem. I can build a clean binbuild.sh tarball by
hand the same way.

> > diff -ur apache_1.3.22/src/helpers/binbuild.sh apache_1.3.22-cygwin/src/helpers/binbuild.sh
> > --- apache_1.3.22/src/helpers/binbuild.sh     Tue Jun 12 08:39:01 2001
> > +++ apache_1.3.22-cygwin/src/helpers/binbuild.sh      Wed Oct 10 14:24:56 2001
> > @@ -55,6 +55,7 @@
> >    rm -rf bindist install-bindist.sh *.bindist
> >    echo "----------------------------------------------------------------------"
&& \
> >    make && \
> > +  if [ "x$MAKERERUN" = "xyes" ]; then make; fi && \
> 
> uhmmm. I am not 100% sure whether ... && if []; then ... fi &&
> will be digested correctly by all shells.

this may not be the best way, I know. The problem is that we currently
require to run "make" twice on Cygwin, because the libhttpd.dll
library is not available while the first run and we have to re-run so
the shared modules can be linked.

Any suggestion on how this may be done better?

> > --- apache_1.3.22/src/helpers/install.sh      Tue Jun 12 10:24:53 2001
> > +++ apache_1.3.22-cygwin/src/helpers/install.sh       Wed Oct 10 15:28:32 2001
> > @@ -90,11 +90,7 @@
> >  #  Check if we need to add an executable extension (such as ".exe")
> >  #  on specific OS to src and dst
> >  if [ -f "$src.exe" ]; then
> > -  if [ -f "$src" ]; then
> > -    : # Cygwin [ test ] is too stupid to do [ -f "$src.exe" ] && [ ! -f
"$src" ]
> > -  else
> > -    ext=".exe"
> > -  fi
> > +  ext=".exe"
> >  fi
> 
> No. We've has that discussion before, and I am not going to switch to
> the ".exe" suffix if both httpd AND httpd.exe happen to reside in my
> unix directory. Therefore I want this extra test. But you could convince
> the cugwin people to fix their implementation of the "test" command, to
> get rid of the comment.

why, httpd.exe is probably only available on Win32 systems, and
install.sh itself is not running on any other OS then Cygwin?!?!

Any other suggestion would be recommended. We _need_ install.sh to run
clean, so "make install" works propably.

> I am unsure about the next one. It looks to me as though the
> logic  would change quite a lot (echo $(shared_dll); execute $(shared_dll);)
> but the Win32, OS/2 and Netware developers should decide about that.
> Maybe it's an improvement - i am simply ignorant.

Makefile.Cygwin is _only_ included via Configure settings for Cygwin,
so there is no impact on other OS.

See ya,
Stipe

tolj@wapme-systems.de
-------------------------------------------------------------------
Wapme Systems AG

Münsterstr. 248
40470 Düsseldorf

Tel: +49-211-74845-0
Fax: +49-211-74845-299

E-Mail: info@wapme-systems.de
Internet: http://www.wapme-systems.de
-------------------------------------------------------------------
wapme.net - wherever you are

Mime
View raw message