httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [PATCH] fix unnecessary logic, fix warning, add comment
Date Thu, 11 Oct 2001 06:15:26 GMT
On Wed, Oct 10, 2001 at 07:36:17PM -0700, Aaron Bannert wrote:
> You'll probably want to commit the following patch as well:
> 
> - converts do-while+if to just a while, so we don't call
>     AP_BRIGADE_EMPTY twice per loop.

Yup.  General goodness.

> - fixes a warning (the *readbytes parameter is an apr_off_t for some reason)

Once things settle down, I'd like to kill apr_off_t in the filters
and always use apr_size_t.  It'd make things so much more consistent.

If anyone wants to enlighten me on the origins of apr_off_t in
the filter code, I'd like to know.

> - adds a little comment to the mystery loop (is my comment correct?)

Looks right.  Just remember that ap_get_client_block should be
called in a loop as well.  =)  Loops in loops in loops.  Oh, what
fun.  

So, +1.  I'll let Ryan sort this out since he committed a 
conflicting patch.  -- justin


Mime
View raw message