httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: error_log hook
Date Mon, 08 Oct 2001 23:16:44 GMT
On Monday 08 October 2001 03:32 pm, Jon Travis wrote:
> The error log hook gets called with the post-formatted string in
> addition to lots of mumbo-jumbo (like the date, remote client, etc.)
> This patch gives authors the ability to use either the stripped down
> log message, or the full one.
>
> This section of code could also use some work (namely removing
> MAX_STRING_LEN from everywhere, and replacing with a sizeof), but this
> keeps the patch small.
>
> As an aside, one could have moved all this formatting functionality into a
> simple core function which hooked into error_log, but as I recall the main
> argument against this was because we wanted to make sure we always got
> errors out to the file (REALLY_FIRST, anyone?)
>
> Anyway, I would appreciate if someone could commit this patch.

This could be solved much more easily by just advancing the errstr string
to be past the date/time portion.  Commit coming within ten minutes.

Ryan

______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message