httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] mod_ssl input filtering...
Date Sat, 06 Oct 2001 16:13:42 GMT
On Sat, Oct 06, 2001 at 04:41:50AM -0400, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
> Hi,
> 	The new patch seems to be the way to go - but I think there's way
> too much overhead here :-(..  I still haven't been able to review/test the
> patch (as i'm totally swamped with my school work)..

Those two statements are contradictory. How can you know about the overhead
if you haven't reviewed the patch?

> A cursory look of the code suggests that we're trying to overdo the
> churn_input activity here (it's probably justified) - but I'm sure it's
> definitely going to adversely affect the SSL performance.. I think it's
> something which is to be kept in mind before the design is complete..
> I'll probably post my comments on the new patch by tommorow.

How about if we get mod_ssl working before worrying about the performance?

> 	Also, Quoting from Bill's mail "Why shouldn't a filter be asked to
> deal with a cumulative 19kb from an 8kb network packet after it's been
> munged by filters below that filter?", I'd also be interested in knowing the
> answer.. 

See my previous response.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message