httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: [PATCH] mod_ssl input filtering...
Date Fri, 05 Oct 2001 22:39:47 GMT
On Friday 05 October 2001 03:34 pm, William A. Rowe, Jr. wrote:
> From: "Justin Erenkrantz" <jerenkrantz@ebuilt.com>
> Sent: Friday, October 05, 2001 4:50 AM

> Now PLEASE understand that maxbytes 0 (originally, the -1 idea) doesn't
> say 'read everything from this socket' --- it leaves the best-fit for
> the underlying filter to decide.  If core wants to give back an even
> number of IP frames, then fine.  If SSL wants to give back an even
> number of decoded SSL packets, also fine.  It will not mean read until
> EOS, ever.  It's up to the underlying filter to decide what is optimal
> for max 0, without allocating a bunch of otherwise useless frame buffers.
>
> And the more that I look at this, the more we need a push-back model,
> because the scope of 'this' filter doesn't live as long as the parent
> filter (with request and connection scopes, respectively.)

A push-back model is not needed.  A filter should not be passing back more
data than the parent can use for this request.  If we need to push data back,
then there is a problem.  When asks for X bytes of data, it is taking 
responsibility for using all X bytes.

Ryan

______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message